-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
colossus s3 api #5150
Open
ignazio-bovo
wants to merge
61
commits into
Joystream:master
Choose a base branch
from
ignazio-bovo:feat/colossus-s3-api
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
colossus s3 api #5150
Changes from all commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
bb9a565
feat: :art: env var in order to run content-directory scenario
4fe88e9
feat: :art: create s3 api model
f9544cf
Merge branch 'master' into feat/colossus-s3-api
ccbf56b
feat: :art: refactor filemodel
5d19954
feat: :art: add connection handler abstract in order to conect to blo…
a1aaed0
refactor: :recycle: connection handlers
73a47b0
feat: :art: file cache improvements
336893e
refactor: :art: refactor to accomodate synch task
4354320
feat: :art: list files functionality
a37dcd4
feat: :art: improvements on connection handlers
940b06f
feat: :art: refactor sync task and add task for remote storage provid…
e697309
feat: :art: renaming the storage provider module and sync/task module…
61e3ac1
feat: :zap: server setup with remote storage provider connection
1363c66
feat: :art: add file verification error class
0df58f1
fix: :fire: add onLocal volume / onCloud Storage flag to data Object …
19cee7c
feat: :art: improve accepted asset logic to accomodate cloud bucket u…
3b72202
fix: :art: upload file flow
99b8ea6
feat: :art: getFile pipe stream
bcd5b12
feat: :zap: adapt abstractConnectionHandler
2395a25
feat: :art: improve S3 connection handler
c05b69a
fix: :bug: list object list ALL objects in the bucket
1bc8dfc
style: :truck: rename files
47f47e5
feat: :zap: setup cloud provider config options
c80488d
fix: :bug: compiler errorrs
c269c10
feat: :art: utilise redirect url for getFile request
b45260b
feat: :art: handle multipart uploads
270ed8f
docs: :memo: update documentation
e87c578
feat: :art: add functionality for removing object from bucket
ac4e9e0
test: :art: setup jest integration tests
3d6d0ea
test: :white_check_mark: finally have a working jest test setup
978b21f
test: :white_check_mark: add unhappy path for move To accepted location
f76ebfd
test: :white_check_mark: add test for sync service
f74cb7d
feat: :art: rewrite file acceptance logic for accept object and sync …
ae0c8b3
test: :white_check_mark: full green test suite for acceptObject
b5e45f5
test: :white_check_mark: add for cache setup
480dbd4
test: :white_check_mark: add for cache setup
b33c9ad
test: :white_check_mark: add test setup with localstack
e75df99
fix: :zap: fix startup flag for storage provider
fc57895
test: :fire: testing
8ae8d77
Merge branch 'petra' into feat/colossus-s3-api
ae510bc
test: :white_check_mark: setup localstack
81ea8fb
fix: :white_check_mark: integration test setup
4954a82
fix: :bento: env variable setup
eaf1d10
fix: :white_check_mark: localstack integration test setup
613ab3a
fix: :memo: docker compose config
9dfa471
refactor: :recycle: refactor docker compose files
196c48c
Merge branch 'master' into feat/colossus-s3-api
a73f483
fix integration tests
mnaamani 967a893
docker compose instead of docker-compose
mnaamani 5e88241
fix used pip before activating venv
mnaamani ae4e1a6
revert docker image names used in local testing
mnaamani 334e2ad
Update .env
9892e01
Update storage-node/src/services/webApi/controllers/filesApi.ts
763f77f
Update tests/network-tests/run-tests.sh
889a5f9
Update docker-compose.localstack.yml
5038ae4
Update storage-node/src/services/helpers/acceptObject.ts
5c7bc1a
Merge branch 'feat/colossus-s3-api' into colossus-s3-api-integration-…
6e1f6e0
Merge pull request #17 from mnaamani/colossus-s3-api-integration-test…
ebd0f03
fix: :zap: add test and configuration for existing file uploads
5959615
feat: :art: adding uploadfile if not exisitng test
e3bece8
fix: :art: overall fixes for awsConnectionHandler test and upload wit…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
The diff you're trying to view is too large. We only load the first 3000 changed files.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -182,7 +182,7 @@ export default class Api { | |
return new Date(blockTime.toNumber()) | ||
} | ||
|
||
protected workingGroupApiQuery<T extends WorkingGroups>(group: T): ApiPromise['query'][typeof apiModuleByGroup[T]] { | ||
protected workingGroupApiQuery<T extends WorkingGroups>(group: T): ApiPromise['query'][(typeof apiModuleByGroup)[T]] { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please checkout any code changes to cli, they all seem to be code style changes and best to be in a different PR. |
||
const module = apiModuleByGroup[group] | ||
return this._api.query[module] | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
services: | ||
localstack: | ||
container_name: local_stack | ||
image: localstack/localstack:3.3 | ||
network_mode: bridge | ||
environment: | ||
- SERVICES=s3 # we only need s3 bucket | ||
- DEBUG=1 | ||
- LOCALSTACK_HOST=${LOCALSTACK_HOST} | ||
ports: | ||
- 4566:4566 | ||
volumes: | ||
- localstack-data:/var/lib/localstack' | ||
|
||
networks: | ||
joystream: | ||
external: true | ||
name: joystream_default | ||
|
||
volumes: | ||
localstack-data: | ||
driver: local |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
version: '3' | ||
|
||
services: | ||
squid_db: | ||
container_name: squid_db | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ENABLE_STORAGE_PROVIDER
andCLOUD_STORAGE_PROVIDER_NAME
probably make more sense as command line arguments.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also we can reduce from two params to just one, the provider name. If not empty string it means we want to use a cloud storage provider.