Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor plots and change terminology #10

Merged
merged 3 commits into from
May 11, 2024
Merged

Refactor plots and change terminology #10

merged 3 commits into from
May 11, 2024

Conversation

Y0dler
Copy link
Collaborator

@Y0dler Y0dler commented May 11, 2024

  1. Change plotting functions in the plots module to allow the usage of said functions without saving the created plots by stating path=None.
  2. Changed mentions of "posterior" to "peak shape" in the models module.

michaelosthege
michaelosthege approved these changes May 11, 2024
View reviewed changes
Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Y0dler Y0dler merged commit f382ef4 into main May 11, 2024
3 of 4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2024
@michaelosthege michaelosthege deleted the refactor-plots branch May 11, 2024 09:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michaelosthege michaelosthege michaelosthege approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Y0dler @michaelosthege