Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Antidifferentiate #130

Closed
wants to merge 2 commits into from
Closed

Antidifferentiate #130

wants to merge 2 commits into from

Conversation

bmxam
Copy link

@bmxam bmxam commented May 11, 2023

Implementation of MultivariatePolynomials.antidifferentiate function. I am more familiar with TypedPolynomials than with DynamicPolynomials so implementations improvements and/or comments are welcome. I did not find tests on the diff function so I did not provide tests for antidifferentiate. However, tests will be added in MultivariatePolynomials.jl (we first need to merge this PR before I can propose the tests).

@blegat
Copy link
Member

blegat commented May 12, 2023

Actually, you can add tests in MultivariatePolynomals now as we are doing a breaking release: JuliaAlgebra/MultivariatePolynomials.jl#250
You can change the branches in .github/workflow/ci.yml so that ci works on the PR.

@bmxam
Copy link
Author

bmxam commented May 12, 2023

Actually, you can add tests in MultivariatePolynomals now as we are doing a breaking release: JuliaAlgebra/MultivariatePolynomials.jl#250 You can change the branches in .github/workflow/ci.yml so that ci works on the PR.

Do you mean changing MultivariatePolynomials.jl/.github/workflow/ci.yml so that MultivariatePolynomials.jl ci works on the present PR?

@blegat
Copy link
Member

blegat commented May 15, 2023

Yes, see what was done in https://github.com/JuliaAlgebra/MultivariatePolynomials.jl/pull/255/files for instance

@blegat
Copy link
Member

blegat commented Jun 27, 2023

You can see an example in #135, JuliaAlgebra/MultivariatePolynomials.jl#268

@bmxam
Copy link
Author

bmxam commented Jun 27, 2023

Thanks, I'll take a look asap.

@blegat
Copy link
Member

blegat commented Apr 30, 2024

Closed by #158

@blegat blegat closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants