zero!(.) -> MA.operate!(zero, .)

JuliaAlgebra · Feb 26, 2024 · 79bbcf8 · 79bbcf8
1 parent 9cd7e19
commit 79bbcf8
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/src/arithmetic.jl b/src/arithmetic.jl
@@ -31,7 +31,7 @@ Base.:^(a::AlgebraElement, p::Integer) = Base.power_by_squaring(a, p)
 
 # mutable API; TODO: replace with MutableArithmetic
 
-function zero!(a::AlgebraElement)
+function MA.operate!(::typeof(zero), a::AlgebraElement)
     MA.operate!(zero, a.coeffs)
     return a
 end
@@ -56,7 +56,7 @@ function add!(res::AlgebraElement, X::AlgebraElement, Y::AlgebraElement)
             res[idx] += x
         end
     else
-        zero!(res)
+        MA.operate!(zero, res)
         for (idx, x) in _nzpairs(coeffs(X))
             res[idx] += x
         end
@@ -77,7 +77,7 @@ end
 function mul!(res::AlgebraElement, X::AlgebraElement, a::Number)
     @assert parent(res) === parent(X)
     if res !== X
-        zero!(res)
+        MA.operate!(zero, res)
     end
     for (idx, x) in _nzpairs(coeffs(X))
         res.coeffs[idx] = a * x

diff --git a/test/arithmetic.jl b/test/arithmetic.jl
@@ -184,7 +184,7 @@
             )
             @test coeffs(Z) == coeffs(W)
 
-            StarAlgebras.zero!(W)
+            MA.operate!(zero, W)
             StarAlgebras.fmac!(coeffs(W), coeffs(X), coeffs(Y), RG.mstructure)
 
             @test coeffs(2 * X * Y) == coeffs(StarAlgebras.mul!(W, W, 2))

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -3,6 +3,7 @@ using StarAlgebras
 import StarAlgebras as SA
 using LinearAlgebra
 using SparseArrays
+import MutableArithmetics as MA
 
 
 include("perm_grp_algebra.jl")