tidy up aug, star and adjoint

JuliaAlgebra · Apr 14, 2024 · f22b273 · f22b273
1 parent 1632be4
commit f22b273
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 5 deletions.
diff --git a/src/algebra_elts.jl b/src/algebra_elts.jl
@@ -27,8 +27,6 @@ end
 
 aug(a::AlgebraElement) = aug(coeffs(a))
 
-Base.adjoint(a::AlgebraElement) = star(a)
-
 function LinearAlgebra.norm(a::AlgebraElement, p::Real)
     return LinearAlgebra.norm(coeffs(a), p)
 end

diff --git a/src/coefficients.jl b/src/coefficients.jl
@@ -68,12 +68,11 @@ function nonzero_pairs(v::AbstractSparseVector)
     return zip(SparseArrays.nonzeroinds(v), SparseArrays.nonzeros(v))
 end
 
+aug(cfs::Any) = sum(values(cfs))
 function aug(ac::AbstractCoefficients)
     isempty(keys(ac)) && return zero(valtype(ac))
     return sum(c * aug(x) for (x, c) in nonzero_pairs(ac))
 end
-aug(v::AbstractVector) = sum(v)
-aug(x::Any) = 1 # ???? dubious...
 
 function LinearAlgebra.norm(sc::AbstractCoefficients, p::Real)
     isempty(keys(sc)) && return (0^p)^1 / p

diff --git a/src/star.jl b/src/star.jl
@@ -1,4 +1,6 @@
+Base.adjoint(a::AlgebraElement) = star(a)
 star(x::Any) = x'
+
 function star(X::AlgebraElement)
     res = star(basis(parent(X)), coeffs(X))
     return AlgebraElement(res, parent(X))

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -22,7 +22,6 @@ begin
 
     # generalities for meaningful *-algebras
     SA.star(g::GroupElement) = inv(g)
-    SA.aug(::GroupElement) = 1
 end
 
 # implementations of the free monoid over an alphabet