Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes for SymbolicWedderburn #26

Merged
merged 27 commits into from
May 12, 2024
Merged

Conversation

kalmarek
Copy link
Collaborator

@blegat there is another "fix" to get going with MA:

this time I had to do this: 56475bf

I've also un-broken two tests that started passing with MA-1.4.3.
However MA.operate_to!(YY, +, Y, YY) still fails with

ERROR: ArgumentError: Cannot call `operate_to!(::SparseVector{Float64, Int64}, +, ::SparseVector{Float64, Int64}, ::SparseVector{Float64, Int64})` as objects of type `SparseVector{Float64, Int64}` cannot be modifed to equal the result of the operation. Use `operate_to!!` instead which returns the value of the result (possibly modifying the first argument) to write generic code that also works when the type cannot be modified.

@kalmarek kalmarek mentioned this pull request Apr 18, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 65.00000% with 35 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (mk/non_monomial_basis@e1a6a6e). Click here to learn what that means.

Files Patch % Lines
src/mtables.jl 53.84% 18 Missing ⚠️
src/diracs_augmented.jl 65.90% 15 Missing ⚠️
src/bases.jl 0.00% 1 Missing ⚠️
src/coefficients.jl 83.33% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##             mk/non_monomial_basis      #26   +/-   ##
========================================================
  Coverage                         ?   77.94%           
========================================================
  Files                            ?       14           
  Lines                            ?      603           
  Branches                         ?        0           
========================================================
  Hits                             ?      470           
  Misses                           ?      133           
  Partials                         ?        0           
Flag Coverage Δ
unittests 77.94% <65.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kalmarek
Copy link
Collaborator Author

kalmarek commented May 9, 2024

ok, I have this running for the whole night with no crashes ;) seems like a fix, but a fix that I don't really understand :D

@blegat
Copy link
Member

blegat commented May 9, 2024

Good news, my plan is to merge jump-dev/SumOfSquares.jl#351 and jump-dev/SumOfSquares.jl#296 to have as much merged as possible without being blocked by StarAlgebras but then the follow up PR will make use of WeightedSOSCone by default which will require custom basis to handle the case with SOS modulo an ideal (I'm planning to implement it with a quotient basis).
In the meantime, maybe we can merge these changes into StarAlgebras#master so that it's easier to deal with since I'll have to make MultivariateMoments, MultivariateBases, PolyJuMP and SumOfSquares depend on it

@kalmarek kalmarek merged commit 7438004 into mk/non_monomial_basis May 12, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants