-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes for SymbolicWedderburn #26
Conversation
This is because isbits elements may not track isdefined / isassigned status. As a consequence Matrix{T}(undef, dims) is initialized to garbage.
Most probably due to Rationals initialized from random memory
the number of allocations on nightly increased due to the introduction of Memory{T} in base julia
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mk/non_monomial_basis #26 +/- ##
========================================================
Coverage ? 77.94%
========================================================
Files ? 14
Lines ? 603
Branches ? 0
========================================================
Hits ? 470
Misses ? 133
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Unbreak broken tests
ok, I have this running for the whole night with no crashes ;) seems like a fix, but a fix that I don't really understand :D |
Good news, my plan is to merge jump-dev/SumOfSquares.jl#351 and jump-dev/SumOfSquares.jl#296 to have as much merged as possible without being blocked by StarAlgebras but then the follow up PR will make use of WeightedSOSCone by default which will require custom basis to handle the case with SOS modulo an ideal (I'm planning to implement it with a quotient basis). |
@blegat there is another "fix" to get going with MA:
this time I had to do this: 56475bf
I've also un-broken two tests that started passing with MA-1.4.3.
However
MA.operate_to!(YY, +, Y, YY)
still fails with