Fix all broken tests but one #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalmarek
requested changes
May 27, 2024
| @@ -188,24 +184,14 @@ | |||
|
|
|||
| @test P2 * P3 == P3 * P2 == P | |||
|
|
|||
| #= | |||
| @test_broken -RG(h) == (-1) * RG(h) | |||
There was a problem hiding this comment.
why does this one remain broken?
There was a problem hiding this comment.
It needs jump-dev/MutableArithmetics.jl#289
There was a problem hiding this comment.
I suggest to leave it for a follow up PR once this MA PR is merged
kalmarek
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started by implementing
operate_to(res, -, a)forAbstractArrays but thenBase.broadcast!would allocate inMA.operate_to!(coeffs(res), +, coeffs(res), coeffs(X))when it would unalias the result from the first argument since they are the same.By merging the two in one line we have a call to
Base.broadcast!with no alias so it seems better :)