-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first attempt at DelayedPosition #434
Open
gpucce
wants to merge
43
commits into
JuliaAnimators:main
Choose a base branch
from
gpucce:add_delayedposition
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
01a4819
first attempt at DelayedPosition
gpucce 64c46ac
reset STARTED_RENDERING at the end of render
gpucce 908819b
Merge branch 'master' into add_delayedposition
gpucce 7d2ab4e
add types to DelayedPosition and add DelayedPosition to Rotation
gpucce c53da96
add first test for delayed
gpucce 5e5d08b
format
gpucce dc47929
fix testset name
gpucce 44807f6
add .keep back
gpucce 473add2
fix test in util not cleaning images folder
gpucce 073a575
adjust testing so .keep does not get removed
gpucce 0003112
format
gpucce a5550c0
Merge remote-tracking branch 'upstream/master' into add_delayedposition
gpucce 64f6f29
add test for rotation and initial support for layers
gpucce f2ce80d
add +,- for betwenn delayedposition and poin
gpucce 3944a90
format tests
gpucce 8e1c204
minor operation change
gpucce a9d3837
add test for +
gpucce dd3e312
add test for delayedposition +/- point both left and right
gpucce c9ff494
change from STARTED_RENDERING to CURRENTLY_RENDERING and add test for it
gpucce 53a8107
adjust to master
gpucce bb316f3
add minimal doc for DelayedPosition
gpucce 8499128
adjust tests
gpucce 4fe938f
doc change
gpucce 5dcf4a2
reset tests
gpucce cad53fe
Merge remote-tracking branch 'upstream/master' into add_delayedposition
gpucce 974dcf0
Merge remote-tracking branch 'upstream/master' into add_delayedposition
gpucce 4d71361
add support for delayed_position in all shorthands except @JShape
gpucce 20e6f40
improve howto
gpucce 4cb3182
Merge branch 'master' of https://github.com/JuliaAnimators/Javis.jl i…
gpucce 4e9c677
fix test
gpucce 16b65d0
add delayed_pos for layers
gpucce 507fbae
fix JEllipse and add more tests
gpucce b7a205b
Change from PointOrDelayed to Luxor.AbstractPoint
gpucce f1fb9e2
format
gpucce e0b6cb7
Minor changes
gpucce a309fb2
reenable some unit tests
gpucce dfe7d49
format
gpucce dce3bda
export get_delayed_position
gpucce 9a24a21
fix types
gpucce a20bd27
add docs to centered_point
gpucce 0b702a1
fix example in howto.md
gpucce 5be8a05
Merge remote-tracking branch 'upstream/main' into add_delayedposition
gpucce 207f03b
update changelog
gpucce File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
mutable struct DelayedPosition | ||
obj | ||
gpucce marked this conversation as resolved.
Show resolved
Hide resolved
|
||
position | ||
called | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to be set to
false
at the end againThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it at the end, maybe it can be reset within the
empy_CURRENT_constants()
after naming itCURRENTLY_RENDERING
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once this works in general
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed STARTED_RENDERING to CURRENTLY_RENDERING
didn't move
CURRENTLY_RENDERING[1] = false
insideempty_CURRENT_variables
because the latter is not called ifpathname
is empty, I don't know if there is a reason for that. if not I can move it inside it and make it a bit cleaner.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should call it in all cases.