Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepped for tagging a v0.8.0 release of Javis #458

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TheCedarPrince
Copy link
Member

PR Checklist

If you are contributing to Javis.jl, please make sure you are able to check off each item on this list:

  • Did I update CHANGELOG.md with whatever changes/features I added with this PR?
  • Did I make sure to only change the part of the file where I introduced a new change/feature?
  • Did I cover all corner cases to be close to 100% test coverage (if applicable)?
  • Did I properly add Javis dependencies to the Project.toml + set an upper bound of the dependency (if applicable)?
  • Did I properly add test dependencies to the test directory (if applicable)?
  • Did I check relevant tutorials that may be affected by changes in this PR?
  • Did I clearly articulate why this PR was made the way it was and how it was made?

Link to relevant issue(s)
Closes N/A

How did you address these issues with this PR? What methods did you use?

As a result of PR #451, since this is a breaking change, we should probably release a new version of Javis.
I went ahead and updated the Changelog as well as Project TOML for the release.
Any more PRs or features we want to introduce before we release a new version?
Maybe we should try to get #399 in as well?

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2022

Codecov Report

Merging #458 (9b9feca) into master (b7f78a4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #458   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files          35       35           
  Lines        1617     1617           
=======================================
  Hits         1560     1560           
  Misses         57       57           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7f78a4...9b9feca. Read the comment docs.

@Wikunia
Copy link
Member

Wikunia commented Jan 19, 2022

LGTM though JavisNB doesn't seemed to be tagged yet, right?
I wouldn't wait for #399 for this release

@gpucce
Copy link
Member

gpucce commented Jan 19, 2022

@Wikunia @TheCedarPrince I have never tagged a release, if we choose to go on before #399 I'd like to do it myself so I know how it works. In case it is complicated or there are things to be particularly careful about you can point me to those.

@Wikunia
Copy link
Member

Wikunia commented Jan 19, 2022

This has to be installed:
https://github.com/JuliaComputing/Registrator.jl#install-registrator
I just checked and it is for all repos of this organization.

Then you need to make sure that the Project.toml is correct (has version 0.1.0, has compat bounds for every package it depends on)
Afterwards you should be able to simply open an issue called releases (actually doesn't matter how you call it)
and call @JuliaRegistrator register() as you can see here: #113

Afterwards a new issue on the JuliaRegistry should be created (the bot will answer your comment in the issue where you called register. We need to wait for 3 days until it is registered.

Then we can continue with v0.8 here

@gpucce
Copy link
Member

gpucce commented Jan 19, 2022

Ok then tomorrow I will do it. Now it would be impossible without mistakes somewhere.

@Wikunia Wikunia changed the base branch from master to main February 25, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants