Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add route tests #28

Merged
merged 2 commits into from
Dec 20, 2014
Merged

add route tests #28

merged 2 commits into from
Dec 20, 2014

Conversation

yfractal
Copy link
Contributor

Add some tests for morsel.

Relate issue: #15

@yfractal
Copy link
Contributor Author

nobody notice this :( ...

@IainNZ
Copy link
Contributor

IainNZ commented Dec 17, 2014

The tests failed, so I think I forgot about it

@IainNZ
Copy link
Contributor

IainNZ commented Dec 17, 2014

You need to add a new commit with a test/REQUIRE file that has FactCheck in it

@yfractal
Copy link
Contributor Author

oh, no i forget the requirement....

I forgot my local Meddle is in mast branch too :( ...

Meddle add params to immutable MeddleRequest in this pr .

but the Meddle's newest release v0.0.5 did not include these change...

And in Morsel, the params have been used, eg: https://github.com/JuliaWeb/Morsel.jl/blob/master/src/Morsel.jl#L197

Should we give the Meddle a new release? Or do something else?

@yfractal
Copy link
Contributor Author

By the way. The pkg in my local.

 - Meddle                      0.0.5+             master
 - HttpCommon             0.0.10
 - HttpServer                 0.0.11

And the test works fine.

Morsel is listening on 8000...
route
get, post, post, put, delete, request
  get
  post, put, delete
5 facts verified.
Add route when the app is running
1 fact verified.
dynamic route
  the request will succes if the type is right
  can get the value by req.params[:id]
  regex route
5 facts verified.
namespace
1 fact verified.
0 facts verified.

@IainNZ
Copy link
Contributor

IainNZ commented Dec 18, 2014

OK so I need to tag a new version of Meddle, then this would work? I can do that - give me ~24 hours or so, I'm travelling right now

@yfractal
Copy link
Contributor Author

Yeah, I think so. Tests will work if i check out to Meddle's master branch.
Thanks and take your time :)
Have a good travelling. :)

@IainNZ
Copy link
Contributor

IainNZ commented Dec 20, 2014

I tagged Meddle v0.0.6, and I've just restarted Travis

@IainNZ
Copy link
Contributor

IainNZ commented Dec 20, 2014

Green light :D

IainNZ added a commit that referenced this pull request Dec 20, 2014
@IainNZ IainNZ merged commit 1e435b6 into JuliaAttic:master Dec 20, 2014
@yfractal
Copy link
Contributor Author

yeah! That's cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants