-
Notifications
You must be signed in to change notification settings - Fork 2
add common interface bindings and tests #28
base: master
Are you sure you want to change the base?
Conversation
Current coverage is 87.47% (diff: 100%)@@ master #28 diff @@
==========================================
Files 14 14
Lines 527 527
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 461 461
Misses 66 66
Partials 0 0
|
1 similar comment
Bump. |
|
||
prob = prob_ode_linear | ||
dt=1/2^(4) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Write as a loop:
for alg in subtypes(ODEIterAlgorithm)
...
@@ -0,0 +1,161 @@ | |||
abstract ODEIterAlgorithm <: AbstractODEAlgorithm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Four spaces indent, if not too much hassle.
kwargs...) | ||
tspan = prob.tspan | ||
|
||
if tspan[end]-tspan[1]<tType(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto (SciML/ODE.jl#119 (comment))
What about the sort(unique(...)) thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the sort(unique(...)) thing?
That's for "saveat" style chosen outputs. The things I tried didn't work, so I just don't have saveat implemented at all in this.
if tspan[end]-tspan[1]<tType(0) | ||
error("final time must be greater than starting time. Aborting.") | ||
end | ||
atomloaded = isdefined(Main,:Atom) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment Check if Juno IDE is used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, this snuck in there. It actually isn't needed.
ode = ODE.ExplicitODE(t,u,f!) | ||
# adaptive==true ? FoA=:adaptive : FoA=:fixed #Currently limied to only adaptive | ||
FoA = :adaptive | ||
if typeof(alg) <: rk23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
algType <: rk23
ks = tmp_dy | ||
end | ||
|
||
saveat_idxs = find((x)->x∈saveat,ts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x ∈ saveat
use spaces
merge(dict1,dict2) | ||
end | ||
|
||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the interpolation stuff go elsewhere as that is not interface specific?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assumed that sooner rather than later you might be replacing it with the interpolation functions that you already have internally (so that way it could also be specialized to the method), but wanted to make sure that the PR at least had the functionality it had before this code was moved.
3 similar comments
I made changes according to @mauro3 's review, along with a few cleanups, including getting rid of all mentions to unused kwargs, changing some of the notation to match the rest of this package, and fixing the indentations. |
This moves the common interface bindings and the tests for PR49 to this package.