Skip to content
This repository has been archived by the owner on Mar 18, 2023. It is now read-only.

add common interface bindings and tests #28

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ChrisRackauckas
Copy link

This moves the common interface bindings and the tests for PR49 to this package.

@codecov-io
Copy link

codecov-io commented Dec 12, 2016

Current coverage is 87.47% (diff: 100%)

Merging #28 into master will not change coverage

@@             master        #28   diff @@
==========================================
  Files            14         14          
  Lines           527        527          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            461        461          
  Misses           66         66          
  Partials          0          0          

Powered by Codecov. Last update e47748b...12dc7ed

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 86.717% when pulling 40f0ace on ChrisRackauckas:common into e47748b on JuliaODE:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 86.717% when pulling 40f0ace on ChrisRackauckas:common into e47748b on JuliaODE:master.

@ChrisRackauckas
Copy link
Author

Bump.


prob = prob_ode_linear
dt=1/2^(4)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write as a loop:

for alg in subtypes(ODEIterAlgorithm)
    ...

@@ -0,0 +1,161 @@
abstract ODEIterAlgorithm <: AbstractODEAlgorithm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Four spaces indent, if not too much hassle.

kwargs...)
tspan = prob.tspan

if tspan[end]-tspan[1]<tType(0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto (SciML/ODE.jl#119 (comment))

What about the sort(unique(...)) thing?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the sort(unique(...)) thing?

That's for "saveat" style chosen outputs. The things I tried didn't work, so I just don't have saveat implemented at all in this.

if tspan[end]-tspan[1]<tType(0)
error("final time must be greater than starting time. Aborting.")
end
atomloaded = isdefined(Main,:Atom)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment Check if Juno IDE is used

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, this snuck in there. It actually isn't needed.

ode = ODE.ExplicitODE(t,u,f!)
# adaptive==true ? FoA=:adaptive : FoA=:fixed #Currently limied to only adaptive
FoA = :adaptive
if typeof(alg) <: rk23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

algType <: rk23

ks = tmp_dy
end

saveat_idxs = find((x)->x∈saveat,ts)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x ∈ saveat use spaces

merge(dict1,dict2)
end

"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the interpolation stuff go elsewhere as that is not interface specific?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed that sooner rather than later you might be replacing it with the interpolation functions that you already have internally (so that way it could also be specialized to the method), but wanted to make sure that the PR at least had the functionality it had before this code was moved.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.476% when pulling ceb0632 on ChrisRackauckas:common into e47748b on JuliaODE:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.476% when pulling ceb0632 on ChrisRackauckas:common into e47748b on JuliaODE:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.476% when pulling ceb0632 on ChrisRackauckas:common into e47748b on JuliaODE:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.476% when pulling ceb0632 on ChrisRackauckas:common into e47748b on JuliaODE:master.

@ChrisRackauckas
Copy link
Author

I made changes according to @mauro3 's review, along with a few cleanups, including getting rid of all mentions to unused kwargs, changing some of the notation to match the rest of this package, and fixing the indentations.

@coveralls
Copy link

coveralls commented Dec 28, 2016

Coverage Status

Coverage remained the same at 87.476% when pulling 12dc7ed on ChrisRackauckas:common into e47748b on JuliaODE:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.476% when pulling 12dc7ed on ChrisRackauckas:common into e47748b on JuliaODE:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.476% when pulling 12dc7ed on ChrisRackauckas:common into e47748b on JuliaODE:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.476% when pulling 12dc7ed on ChrisRackauckas:common into e47748b on JuliaODE:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.476% when pulling 12dc7ed on ChrisRackauckas:common into e47748b on JuliaODE:master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants