benchmark worker updates #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
reviewed
Nov 8, 2022
maleadt
reviewed
Nov 8, 2022
| @@ -340,7 +340,7 @@ function execute_benchmarks!(job::BenchmarkJob, juliapath, whichbuild::Symbol) | |||
| run(`$(git()) -C $BaseBenchmarks reset --hard --quiet origin/$(branchname)`) | |||
| end | |||
|
|
|||
| run(sudo(cfg.user, setenv(`$(setenv(juliacmd, nothing)) -e 'using Pkg; Pkg.instantiate(); Pkg.status()'`; dir=builddir))) | |||
| run(sudo(cfg.user, `$(setenv(juliacmd, nothing, dir=builddir)) -e 'using Pkg; Pkg.instantiate(); Pkg.status()'`)) | |||
There was a problem hiding this comment.
Why does this need to happen in the builddir if its just using the global environment anyway?
There was a problem hiding this comment.
it gets moved to sudo either way
|
now failing with |
|
Yeah sorry for the typo's. It's too bad that it's near-impossible to test the benchmark bot, since the code and configuration here is so specific to your set-up (e.g., |
|
There is a script to activate a machine as a worker (only do this inside docker, or a machine you actually want to convert though). But not to worry either, as these were pretty simple, and I just run a few trial of nanosoldier whenever I go to update it to check |
vtjnash
force-pushed
the
jn/benchmark-updates
branch
from
dfab61e to
e641f52
Compare
vtjnash
force-pushed
the
jn/benchmark-updates
branch
from
b0142a1 to
c926fb4
Compare
This makes it easier for anyone with access to log in and view or change the live status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I knew about the sudo-interpolation-ENV thing, I just have not been good about making PRs for my branches