don't use PkgServers in Documenter job #296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version of the registry served by PkgServers can sometimes lag a little bit behind, leading to issues such as in JuliaDiff/FiniteDifferences.jl#173. The `julia-buildpkg` action actually already does this here: https://github.com/julia-actions/julia-buildpkg/blob/1b0a69ab74709d3707f86249fce805049212961a/action.yml#L22
|
The better approach is not to completely opt-out of the Pkg server, but rather to use Git for the General registry. Then you can still use the Pkg server by default, and call back to GitHub as necessary. So I would recommend that instead of just opting out of the Pkg server, take the approach from e.g. julia-actions/julia-runtest#17. |
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
=======================================
Coverage 94.40% 94.40%
=======================================
Files 20 20
Lines 608 608
=======================================
Hits 574 574
Misses 34 34 Continue to review full report at Codecov.
|
|
Bump. @DilumAluthge does that look good to you? |
|
resolved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of the registry served by PkgServers can sometimes lag a
little bit behind, leading to issues such as in JuliaDiff/FiniteDifferences.jl#173.
The
julia-buildpkgaction actually already does this here:https://github.com/julia-actions/julia-buildpkg/blob/1b0a69ab74709d3707f86249fce805049212961a/action.yml#L22