Use coarse data first to make zooming smooth #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixcremer
requested changes
Jul 29, 2024
| @@ -128,6 +128,11 @@ function Base.map(f, A::Pyramid) | |||
| Pyramid(newbase, newlevels, DD.metadata(A)) # This should handle metadata better. | |||
| end | |||
|
|
|||
| function DiskArrays.cache(p::Pyramid; maxsize=1000) | |||
| maxsize = maxsize ÷ (length(p.levels) + 1) | |||
| Pyramid(DiskArrays.cache(p.base; maxsize), DiskArrays.cache.(p.levels; maxsize), p.metadata) | |||
There was a problem hiding this comment.
We might want to use the setter functions here instead of the access to the fields of the struct. So it should be parent(p) instead of p.base and DD.metadata(p) instead of p.metadata.
| #First load overview | ||
| overview1 = min(n_agg + 4, nlevels(pyramid)) | ||
| data = levels(pyramid)[overview1][ext] | ||
| odata = Observable{Any}(data) |
There was a problem hiding this comment.
Why is this an Observable{Any} should we restrict this to AbstractDimArray?
|
I also get this strange behaviour at some zoom steps. This is way faster on the screen than on the screencast. It seems as if we can hit some update loops. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I played a bit with the plotting script and adapted it so that it falls back to coarser levels when zooming in and the new data is not loaded yet. This results in smoother zooming although this could still be optimised.