-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic sparse handling #246
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
4da1f56
add some sparse handling
0c27ac0
add a basic test
e51c952
add to tests
05ce024
typeof -> Type
6ae7005
typo
818b8a3
mv diagm,issymmetric to LA
f04ede8
follow blue style
f27d579
better test
580ed80
add matrix rrule
3cdd2d6
style cleanups
dd392a8
use test_rrule instead
82bec3d
test for SparseMatricCSC instead
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
using SparseArrays | ||
|
||
function rrule(::Type{<:SparseMatrixCSC{T,N}}, arr) where {T,N} | ||
function SparseMatrix_pullback(Δ) | ||
return NO_FIELDS, collect(Δ) | ||
end | ||
return SparseMatrixCSC{T,N}(arr), SparseMatrix_pullback | ||
end | ||
|
||
function rrule(::typeof(Matrix), x::SparseMatrixCSC) | ||
function Matrix_pullback(Δ) | ||
NO_FIELDS, Δ | ||
end | ||
return Matrix(x), Matrix_pullback | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
using SparseArrays | ||
|
||
@testset "Sparse" begin | ||
r = sparse(rand(3,3)) | ||
x, x̄ = rand(3,3), rand(3,3) | ||
test_rrule(SparseMatrixCSC, r) | ||
test_rrule(Matrix, r) | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a full review, but just so it doesn't get missed, it is the pattern of this package, inline with BlueStyle,
to do all the
using
s at the top level file