Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcasting #644

Merged
merged 20 commits into from
Aug 9, 2022
Merged

Broadcasting #644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
aec3dd2
broadcasting, adapted from Diffractor PR68
mcabbott Jul 8, 2022
74981cd
many small upgrades
mcabbott Jul 12, 2022
74a6a8b
fixup tuplecast
mcabbott Jul 12, 2022
3319600
re-organise split bc, add forward mode
mcabbott Jul 12, 2022
070d4b7
fix tests
mcabbott Jul 12, 2022
62d5145
add Yota to downstream tests
mcabbott Jul 12, 2022
818147a
fix an ambiguity
mcabbott Jul 12, 2022
3d4d9b2
fix tests on 1.6
mcabbott Jul 13, 2022
5c35f9c
testing
mcabbott Jul 14, 2022
54bfee2
improve unbroadcast
mcabbott Aug 6, 2022
888ddc1
change generic rule to use BroadcastStyle
mcabbott Aug 6, 2022
d4e4e51
debug
mcabbott Aug 6, 2022
fca9a75
rename with unzip
mcabbott Aug 6, 2022
91b5405
fix for 1.6
mcabbott Aug 6, 2022
9d5dad7
test bugs
mcabbott Aug 6, 2022
45102c5
version
mcabbott Aug 8, 2022
ccbe561
tidy unzipped
mcabbott Aug 8, 2022
609196a
add some GPU tests
mcabbott Aug 8, 2022
85aa2fa
remove fallback unbroadcast method
mcabbott Aug 8, 2022
b7e63f5
re-instate the error which breaks Revise
mcabbott Aug 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/IntegrationTest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ jobs:
os: [ubuntu-latest]
package:
# - {user: dpsanders, repo: ReversePropagation.jl}
- {user: dfdx, repo: Yota.jl}
- {user: FluxML, repo: Zygote.jl}
# Diffractor needs to run on Julia nightly
# include:
Expand Down
4 changes: 3 additions & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "ChainRules"
uuid = "082447d4-558c-5d27-93f4-14fc19e9eca2"
version = "1.42.0"
version = "1.43.0"

[deps]
ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
Expand All @@ -13,6 +13,7 @@ Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
RealDot = "c1ae055f-0cd5-4b69-90a6-9a35b1a98df9"
SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
StructArrays = "09ab397b-f2b6-538f-b94a-2f83cf4a842a"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add compat for this. and up the version number

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


[compat]
ChainRulesCore = "1.15.3"
Expand All @@ -25,6 +26,7 @@ JLArrays = "0.1"
JuliaInterpreter = "0.8,0.9"
RealDot = "0.1"
StaticArrays = "1.2"
StructArrays = "0.6.11"
julia = "1.6"

[extras]
Expand Down
6 changes: 6 additions & 0 deletions src/ChainRules.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,15 @@ using Base.Broadcast: materialize, materialize!, broadcasted, Broadcasted, broad
using ChainRulesCore
using Compat
using Distributed
using GPUArraysCore: AbstractGPUArrayStyle
using IrrationalConstants: logtwo, logten
using LinearAlgebra
using LinearAlgebra.BLAS
using Random
using RealDot: realdot
using SparseArrays
using Statistics
using StructArrays

# Basically everything this package does is overloading these, so we make an exception
# to the normal rule of only overload via `ChainRulesCore.rrule`.
Expand All @@ -22,6 +24,9 @@ using ChainRulesCore: derivatives_given_output
# numbers that we know commute under multiplication
const CommutativeMulNumber = Union{Real,Complex}

# StructArrays
include("unzipped.jl")

include("rulesets/Core/core.jl")

include("rulesets/Base/utils.jl")
Expand All @@ -34,6 +39,7 @@ include("rulesets/Base/arraymath.jl")
include("rulesets/Base/indexing.jl")
include("rulesets/Base/sort.jl")
include("rulesets/Base/mapreduce.jl")
include("rulesets/Base/broadcast.jl")

include("rulesets/Distributed/nondiff.jl")

Expand Down
2 changes: 2 additions & 0 deletions src/rulesets/Base/base.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ function rrule(::Type{T}, x::Number, y::Number) where {T<:Complex}
return (T(x, y), Complex_pullback)
end

@scalar_rule complex(x) true

# `hypot`

@scalar_rule hypot(x::Real) sign(x)
Expand Down
Loading