Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overload FiniteDifferences.to_vec for Composite #24

Closed
oxinabox opened this issue Apr 24, 2020 · 3 comments · Fixed by #25
Closed

Overload FiniteDifferences.to_vec for Composite #24

oxinabox opened this issue Apr 24, 2020 · 3 comments · Fixed by #25
Labels
wontfix This will not be worked on

Comments

@oxinabox
Copy link
Member

needed for JuliaDiff/ChainRules.jl#175
@oxinabox oxinabox mentioned this issue Apr 27, 2020
Merged
@oxinabox
Copy link
Member Author

writing the to_vec for Composite of a struct is fiddly.
Since fields might be in a different order and some might be missing.

I think easiest is probably to use canonicalize to force everything into some fields and order as the primal type, and fill in any zeros.
Though that also means assing support for Zero so many not?

Luckily once we solve to_vec we solve isapprox basically for free.

@oxinabox oxinabox reopened this Apr 28, 2020
@willtebbutt willtebbutt mentioned this issue Jul 11, 2020
Open
@nickrobinson251
Copy link
Contributor

alternative proposal that would make this redundant JuliaDiff/FiniteDifferences.jl#97
(the intention is to do that, instead of overloading to_vec)

@nickrobinson251 nickrobinson251 added the wontfix This will not be worked on label Aug 4, 2020
@nickrobinson251
Copy link
Contributor

xref JuliaDiff/FiniteDifferences.jl#105

@oxinabox oxinabox mentioned this issue Oct 12, 2020
Merged
@oxinabox oxinabox reopened this Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Composite{<:Tuple} work JuliaDiff/ChainRulesTestUtils.jl
2 participants
@oxinabox @nickrobinson251