Defined to_vec for ChainRulesCore differential types #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 12, 2020
nickrobinson251
approved these changes
Oct 12, 2020
There was a problem hiding this comment.
Presuming the test failure is fixed by JuliaDiff/ChainRulesCore.jl#230
oxinabox
commented
Oct 12, 2020
willtebbutt
approved these changes
Oct 12, 2020
Update src/to_vec.jl Co-authored-by: Nick Robinson <[email protected]> Update src/to_vec.jl
oxinabox
force-pushed
the
ox/chainrule_types
branch
from
4063d84 to
c8c2158
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already had ChainRulesCore as a dependency.
ChainRulesTestUtils was type-piratically defining
to_veconComposite{<:Tuple, <:Tuple}This PR adds for
AbstractZero(useful if working with a deep structure containing some Zero parts).and it adds for
Compositeon structs.Supporting to_vec on Composites of structs will close the last parts of
JuliaDiff/ChainRulesTestUtils.jl#24
which really should have been on this repo.
I don't think it alone is enough to do finite differencing on structs, but it is a first step.
This works without JuliaDiff/ChainRulesCore.jl#230
but for the tests to pass it needs that, since equality was defined wong