Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect array type in wrong-mode pushforward/pullback #620

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Nov 10, 2024

DI source

  • In pushforward/pullback, give x/y as a first argument to the map over cartesian indices. This allows array types (e.g. static or GPU) to be preserved.

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.44%. Comparing base (8ef803c) to head (0955815).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...rentiationInterface/src/first_order/pushforward.jl 50.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (8ef803c) and HEAD (0955815). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (8ef803c) HEAD (0955815)
DIT 8 6
DI 37 9
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #620       +/-   ##
===========================================
- Coverage   97.95%   64.44%   -33.51%     
===========================================
  Files         119      114        -5     
  Lines        6246     6258       +12     
===========================================
- Hits         6118     4033     -2085     
- Misses        128     2225     +2097     
Flag Coverage Δ
DI 53.79% <75.00%> (-45.13%) ⬇️
DIT 86.96% <ø> (-8.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle marked this pull request as draft November 13, 2024 09:27
@gdalle
Copy link
Member Author

gdalle commented Feb 9, 2025

The issue at the moment is with GPUArrays because CartesianIndices(x) is not a GPU array

@gdalle gdalle marked this pull request as ready for review February 9, 2025 23:45
@gdalle gdalle marked this pull request as draft March 13, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant