WIP: Change matrix to_vec semantics #187
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to / resolves #132
Since
ChainRulesTestUtils
no longer relies on checking equality in theto_vec
ed space (I don't believe), we're freed up to make this change.In short: after this change, it will generally be a really bad idea to check equality in the
to_vec
ed space (I think it was probably a bad idea anyway to be honest, because it's generally a lossy transformation).The motivation for making this PR now was that I was trying to implement some
rrule
s, and encountered the issue thatto_vec(rand_tangent(::Diagonal))
andto_vec(::Diagonal)
yield different sized vectors, which causes problems withFiniteDifferences
'sjpvp
and / orjvp
functionality.ToDo: