Merge pull request #304 from JuliaDiff/gd/remove_inbounds

Remove or sanitize inbounds
JuliaDiff · Oct 7, 2024 · 4e277d1 · 4e277d1
2 parents 20e4c03 + c153d75
commit 4e277d1
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/ext/SparseDiffToolsPolyesterExt.jl b/ext/SparseDiffToolsPolyesterExt.jl
@@ -57,7 +57,7 @@ function polyesterforwarddiff_color_jacobian(J::AbstractMatrix{<:Number}, f::F,
                              if colorvec[cols_index[idx]] == color_i]
                 rows_index_c = rows_index[pick_inds]
                 cols_index_c = cols_index[pick_inds]
-                @inbounds @simd for i in 1:length(rows_index_c)
+                @simd for i in eachindex(rows_index_c, cols_index_c)
                     J[rows_index_c[i], cols_index_c[i]] = dx[rows_index_c[i]]
                 end
                 color_i += 1

diff --git a/src/coloring/matrix2graph.jl b/src/coloring/matrix2graph.jl
@@ -45,7 +45,7 @@ function matrix2graph(sparse_matrix::AbstractSparseMatrix{<:Number},
 
     if partition_by_rows
         rows_by_cols = _rows_by_cols(rows_index, cols_index)
-        @inbounds for (cur_row, cur_col) in zip(rows_index, cols_index)
+        for (cur_row, cur_col) in zip(rows_index, cols_index)
             if !isempty(rows_by_cols[cur_col])
                 for next_row in rows_by_cols[cur_col]
                     if next_row < cur_row
@@ -56,7 +56,7 @@ function matrix2graph(sparse_matrix::AbstractSparseMatrix{<:Number},
         end
     else
         cols_by_rows = _cols_by_rows(rows_index, cols_index)
-        @inbounds for (cur_row, cur_col) in zip(rows_index, cols_index)
+        for (cur_row, cur_col) in zip(rows_index, cols_index)
             if !isempty(cols_by_rows[cur_row])
                 for next_col in cols_by_rows[cur_row]
                     if next_col < cur_col

diff --git a/src/differentiation/compute_jacobian_ad.jl b/src/differentiation/compute_jacobian_ad.jl
@@ -366,7 +366,7 @@ function forwarddiff_color_jacobian!(J::AbstractMatrix{<:Number},
         partial_i = p[i]
 
         if vect isa Array
-            @inbounds @simd ivdep for j in eachindex(vect)
+            @inbounds @simd ivdep for j in eachindex(vect, vecx, partial_i)
                 vect[j] = eltype(t)(vecx[j], ForwardDiff.Partials(partial_i[j]))
             end
         else
@@ -377,7 +377,7 @@ function forwarddiff_color_jacobian!(J::AbstractMatrix{<:Number},
         if !(sparsity isa Nothing)
             for j in 1:chunksize
                 if dx isa Array
-                    @inbounds @simd for k in eachindex(dx)
+                    @inbounds @simd for k in eachindex(dx, fx)
                         dx[k] = partials(fx[k], j)
                     end
                 else
@@ -429,7 +429,7 @@ function forwarddiff_color_jacobian!(J::AbstractMatrix{<:Number},
                 col_index = (i - 1) * chunksize + j
                 (col_index > ncols) && return J
                 if J isa Array
-                    @inbounds @simd for k in 1:size(J, 1)
+                    @simd for k in axes(J, 1)
                         J[k, col_index] = partials(vecfx[k], j)
                     end
                 else