-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tag
kwarg to JacVec, HesVec, HesVecGrad
#241
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #241 +/- ##
=======================================
Coverage 84.76% 84.76%
=======================================
Files 14 14
Lines 952 952
=======================================
Hits 807 807
Misses 145 145
☔ View full report in Codecov by Sentry. |
@Vaibhavdixit02 , @YingboMa can you review and merge this? It's blocking other PRs |
This needs a test so it doesn't regress again. |
added some tests here. After the ODE PR is merged, we can add ODE tests in this repo, as well as downstream tests to OrdinaryDiffEq in SparseDiffTools. |
@ChrisRackauckas take a look. more comprehensive tests can be added only after ODE.jl supports sparsediff v2.
|
This will fix errors in SciML/OrdinaryDiffEq.jl#1917 by allowing
OrdinaryDiffEq
to pass the rightForwardDiff.tag
toJacVec
.