Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying colorvecs directly #259

Merged
merged 2 commits into from
Sep 9, 2023
Merged

Allow specifying colorvecs directly #259

merged 2 commits into from
Sep 9, 2023

Conversation

avik-pal
Copy link
Contributor

@avik-pal avik-pal commented Sep 7, 2023

In NonlinearSolve.jl we often have precomputed sparsity patterns, aka, colorvec (SciML/NonlinearSolve.jl#203). This allows us to use that.

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 87.09% and project coverage change: -0.10% ⚠️

Comparison is base (6bb4839) 87.52% compared to head (a6731aa) 87.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
- Coverage   87.52%   87.42%   -0.10%     
==========================================
  Files          21       21              
  Lines        1178     1201      +23     
==========================================
+ Hits         1031     1050      +19     
- Misses        147      151       +4     
Files Changed Coverage Δ
src/SparseDiffTools.jl 100.00% <ø> (ø)
src/highlevel/common.jl 87.50% <84.00%> (-5.61%) ⬇️
src/highlevel/coloring.jl 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants