-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for erf #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add the dependency in the folder benchmark as well.
The manifest file must be added as well. |
Why don't you instantiate the package? Usually you don't commit the Manifest file. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 86.25% 86.30% +0.05%
==========================================
Files 6 6
Lines 240 241 +1
==========================================
+ Hits 207 208 +1
Misses 33 33
☔ View full report in Codecov by Sentry. |
The reason for committing |
solves #48