Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IA 0.22 #345

Merged
merged 18 commits into from
Mar 31, 2025
Merged

Update IA 0.22 #345

merged 18 commits into from
Mar 31, 2025

Conversation

lbenet
Copy link
Member

@lbenet lbenet commented Dec 12, 2023

No description provided.

@lbenet lbenet changed the title Updates related to IntervalArithmetic (towards IA 1.0) Towards IA 1.0 Dec 13, 2023
@coveralls
Copy link

coveralls commented Dec 13, 2023

Coverage Status

coverage: 92.121% (-3.0%) from 95.081%
when pulling 4fe180d on lb/IA_1.0-dev
into 0298820 on master.

@lbenet
Copy link
Member Author

lbenet commented Dec 14, 2023

Tests are broken in Julia v1.6 because IA imposes Julia v1.9...

@lbenet
Copy link
Member Author

lbenet commented Jan 19, 2024

Due to IntervalArithmetic requiring v1.9 of julia, the tests fail for Julia v1.6...

@OlivierHnt
Copy link

Out of curiosity, what is the status of this PR? Are there any unresolved issues?

@lbenet
Copy link
Member Author

lbenet commented Oct 24, 2024

Thanks @OlivierHnt for asking; so far so good (in terms of unresolved issues), though I haven't checked how things work after JuliaIntervals/IntervalArithmetic.jl#686. Things to do here are related to the ambiguities that generate IntervalArithmetic that affect the performance. (That's part of the reason I started to work on JuliaIntervals/IntervalArithmetic.jl#687.) I am also rewriting in #369 some parts related to pow (^), which will require some updates here.

It's been a quite stressfull semester, which has slowed down some of my efforts here (and in IntervalArithmetic); I hope to have more time in November...

@OlivierHnt
Copy link

Sounds great :)
Huh I did not know that ambiguities can affect the performance.

@lbenet lbenet changed the title Towards IA 1.0 Update IA 0.22 Mar 21, 2025
@lbenet lbenet marked this pull request as ready for review March 21, 2025 16:44
@lbenet
Copy link
Member Author

lbenet commented Mar 21, 2025

@lrnv This branch upgrades what a bunch of things related to the use of IntervalArithmetic.jl in its very last development version, including some changes in evaluate and pow. This forces a new minor version release. I don't know if you use these things in your packages, but expect a CompatHelper notice. If you do, it would be very helpful if you can test this changes in your packages, or just simply let me know which packages you develop use TaylorSeries, and I'll do the tests.

@lbenet
Copy link
Member Author

lbenet commented Mar 21, 2025

@PerezHz There seems to be issues for JLD2 in Julia nightly; any ideas?

@lrnv
Copy link

lrnv commented Mar 21, 2025

@lbenet Thanks for pinging me there !

The package I use TaylorSeries in are WilliamsonTransforms.jl and Copulas.jl. If you want to check their tests yourself you can of course !

Otherwise please do what you have to do, publish your minor version, CompatHelper will do its job and if i have issues I'll come back to you.

@PerezHz
Copy link
Contributor

PerezHz commented Mar 23, 2025

@PerezHz There seems to be issues for JLD2 in Julia nightly; any ideas?

I tried reproducing the error on current nightly (1.13.0-DEV.284, macOS) but didn't manage (tests pass). The error points to JLD2.jl erroring during compilation which could point to an error from JLD2.jl or the specific nightly. Have you already tried simply rerunning?

@PerezHz
Copy link
Contributor

PerezHz commented Mar 23, 2025

The failing tests on nightly used JLD2 v0.5.11; I tested locally with JLD2 v0.5.12 which was released yesterday including a fix for the errors in nightly, so tests should pass now there (if it manages to catch the new JLD2 version, which it should).

@lbenet
Copy link
Member Author

lbenet commented Mar 23, 2025

The failing tests on nightly used JLD2 v0.5.11; I tested locally with JLD2 v0.5.12 which was released yesterday including a fix for the errors in nightly, so tests should pass now there (if it manages to catch the new JLD2 version, which it should).

I just checked the tests, and you are right. So I will relauch the tests. Thanks @PerezHz for checking it!

Sbozzolo added a commit to CliMA/CubedSphere.jl that referenced this pull request Mar 25, 2025
JuliaDiff/TaylorSeries.jl#345 will add support
to a newer version of IntervalArithmetics. This is needed to support
recent versions of Makie.

JuliaDiff/TaylorSeries.jl#345 bumps the version
of TaylorSeries to 0.19, and this commit expands compat for that.

CubedSphere.jl does not use IntervalArithmetics, so it is still
compatible with 0.19.

I tested 345 locally and the test suite for CubedSphere passes.

(We can merge this after TaylorSeries 0.19 is released)
@lbenet
Copy link
Member Author

lbenet commented Mar 28, 2025

The package I use TaylorSeries in are WilliamsonTransforms.jl and Copulas.jl. If you want to check their tests yourself you can of course !

Very busy week(s), sorry for the silence @lrnv ...

I've checked that WilliamsonTransforms.jl and Copulas.jl do not use IntervalArithmetic.jl, which then makes a priori irrelevant to upgrade to TaylorSeries 0.19; in any case, tests pass correctly for both packages (dev-ing TaylorSeries in each case, and fixing the Project.toml).

Yet, I notice that Copulas compat version of Julia is 1.6; TaylorSeries now requires v1.10 (changed recently from 1, which i think corresponds to the lts, i.e., 1.10. I'm just pointing this out because it may be a source of troubles.

@lbenet lbenet linked an issue Mar 30, 2025 that may be closed by this pull request
@lbenet
Copy link
Member Author

lbenet commented Mar 31, 2025

I've checked that some packages that depend on TaylorSeries have passing tests with this PR. These packages include TaylorIntegration, PlanetaryEphemeris and NEOs; yet, TaylorModels depends on both, TaylorSeries and IntervalArithmetic, so it has to be considered separately.

I'm thus merging this PR and tagging a new version.

@lbenet lbenet merged commit 7dc2c39 into master Mar 31, 2025
14 checks passed
@lbenet lbenet deleted the lb/IA_1.0-dev branch March 31, 2025 01:51
@lrnv
Copy link

lrnv commented Mar 31, 2025

Yet, I notice that Copulas compat version of Julia is 1.6; TaylorSeries now requires v1.10 (changed recently from 1, which i think corresponds to the lts, i.e., 1.10. I'm just pointing this out because it may be a source of troubles.

I guess that this is not as issue, since for someone using an older version of Julia, an older version of TaylorSeries.jl would be used right ?

Anyway, thanks for checking, for the moment I ran tests and merged the compat PRs so we are good. Ty !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with IntervalArithmetic 0.22
5 participants