-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Program from sh_string_type #103
Open
Tuebel
wants to merge
21
commits into
JuliaGL:master
Choose a base branch
from
Tuebel:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge upstream
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
- Coverage 34.17% 32.89% -1.29%
==========================================
Files 15 15
Lines 1308 1356 +48
==========================================
- Hits 447 446 -1
- Misses 861 910 +49
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Texture does not fully implement GPUArray interface - not a subtype anymore. Cleanup commented code.
Fix OpenGL error due to calling glUseProgram in wrong state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling shader programs as described in https://github.com/JuliaGL/GLAbstraction.jl/blob/master/example/drawing_polygons_with_GLAbstraction.jl via
GLA.frag
andProgram(sh_string_type...)
gave me an Error:I think the method broke here: a6076c8#diff-8728a176445e31cf3b9dc440a8dd9fd201f9aa51f761e51115ff058ffb408a11R76
Unpacking the tuple as argument for the Shader fixed it.