Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Program from sh_string_type #103

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

fix Program from sh_string_type #103

wants to merge 21 commits into from

Conversation

Tuebel
Copy link

@Tuebel Tuebel commented Jul 18, 2021

Compiling shader programs as described in https://github.com/JuliaGL/GLAbstraction.jl/blob/master/example/drawing_polygons_with_GLAbstraction.jl via GLA.frag and Program(sh_string_type...) gave me an Error:

MethodError: no method matching GLAbstraction.Shader(::Tuple{UInt32, String})

I think the method broke here: a6076c8#diff-8728a176445e31cf3b9dc440a8dd9fd201f9aa51f761e51115ff058ffb408a11R76

Unpacking the tuple as argument for the Shader fixed it.

@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2022

Codecov Report

Merging #103 (dd550ca) into master (534f6f9) will decrease coverage by 1.28%.
The diff coverage is 29.80%.

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
- Coverage   34.17%   32.89%   -1.29%     
==========================================
  Files          15       15              
  Lines        1308     1356      +48     
==========================================
- Hits          447      446       -1     
- Misses        861      910      +49     
Impacted Files Coverage Δ
src/GLAbstraction.jl 0.00% <ø> (ø)
src/buffer.jl 30.40% <0.00%> (ø)
src/framebuffer.jl 0.00% <0.00%> (ø)
src/vertexarray.jl 50.79% <0.00%> (-0.80%) ⬇️
src/shader/shader.jl 31.57% <25.00%> (ø)
src/texture.jl 46.34% <43.43%> (-2.38%) ⬇️
src/for_moderngl.jl 50.00% <68.00%> (+2.22%) ⬆️
src/shader/program.jl 38.40% <100.00%> (ø)
src/context.jl 56.00% <0.00%> (-7.64%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants