This repository has been archived by the owner on Apr 28, 2021. It is now read-only.
moved some functionality to GLFW.jl #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start of restructuring
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start of restructuring.
gl_createcontextout ofGLWindow.jl/screen.jlto a constructor forGLFW.Window.GLFW.Windowrelated functionality fromGLWindow.jl/screen.jl,types.jl,core.jltoGLFW/types.jl.MonitorPropertiesfromGLWindow.jl/types.jltoGLFW/types.jlMonitorPropertiesso it doesn't depend onGeometryTypes: Vechit in performance shouldn't matter imo.GLFW.jlrelated functionality fromGLWindow/screen.jl,core.jltoGLFW/extensions.jlTests work, also ran the tests for the pullrequest in
GLFW.jlGeneral Idea: Firstly, splitting pure
GLFW.jlrelated functionality fromGLWindow.jlwill allow it to be less backend specific, and act as a interface to differentOpenGLwindow/context providers. This is in light of hopefully seperating Windowing functionality in 'GLWindow' fromGLAbstraction.jland provide more of anAPIexperience.Secondly, I understand this makes the package no-longer a barebones wrap around the
GLFWlibrary, but was it really purely that to begin with, and would people not use the added functionality that only depends onGLFWif it is there?If the authors of
GLFW.jlwant to keep it a barebones library, as is right now, we might be mimicking these changes into a folderbackendswhere the backend specific things are implemented, or submodules...