Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CUDNN-optimized activation broadcasts #515

Merged
merged 2 commits into from
Oct 29, 2020
Merged

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Oct 29, 2020

Fixes:

julia> x = CUDA.ones(1); tanh.(x); x
1-element CuArray{Float32,1}:
 0.7615942

julia> x = CUDA.ones(1); tan.(x); x
1-element CuArray{Float32,1}:
 1.0

Introduced by #321, discovered while debugging FluxML/Flux.jl#1367

@maleadt maleadt added cuda array Stuff about CuArray. bugfix This gets something working again. labels Oct 29, 2020
@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #515 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
+ Coverage   80.52%   80.54%   +0.02%     
==========================================
  Files         166      166              
  Lines        8884     8884              
==========================================
+ Hits         7154     7156       +2     
+ Misses       1730     1728       -2     
Impacted Files Coverage Δ
lib/cudnn/activation.jl 100.00% <ø> (ø)
lib/cudnn/tensor.jl 59.52% <ø> (ø)
test/cudnn.jl 26.66% <ø> (ø)
lib/cudnn/nnlib.jl 70.00% <100.00%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c70bb39...beffb7d. Read the comment docs.

@maleadt maleadt merged commit 836de1d into master Oct 29, 2020
@maleadt maleadt deleted the tb/cudnn_broadcast branch October 29, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This gets something working again. cuda array Stuff about CuArray.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant