Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accomodate for rectangular matrices in copytrito! #538

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Accomodate for rectangular matrices in copytrito! #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4f94c1
Accomodate for rectangular matrices in copytrito!
amontoison May 30, 2024
37d2f39
Add tests with rectangular matrices
amontoison Oct 29, 2024
e322a31
Don't use lacpy_size_check
amontoison Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/host/linalg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,12 @@ if isdefined(LinearAlgebra, :copytrito!)
LinearAlgebra.BLAS.chkuplo(uplo)
m,n = size(A)
m1,n1 = size(B)
(m1 < m || n1 < n) && throw(DimensionMismatch("B of size ($m1,$n1) should have at least the same number of rows and columns than A of size ($m,$n)"))
if uplo == 'U'
if n < m
(m1 < n || n1 < n) && throw(DimensionMismatch("B of size ($m1,$n1) should have at least size ($n,$n)"))
else
(m1 < m || n1 < n) && throw(DimensionMismatch("B of size ($m1,$n1) should have at least size ($m,$n)"))
end
@kernel function U_kernel!(_A, _B)
I = @index(Global, Cartesian)
i, j = Tuple(I)
Expand All @@ -122,6 +126,11 @@ if isdefined(LinearAlgebra, :copytrito!)
end
U_kernel!(get_backend(B))(A, B; ndrange = size(A))
else # uplo == 'L'
if m < n
(m1 < m || n1 < m) && throw(DimensionMismatch("B of size ($m1,$n1) should have at least size ($m,$m)"))
else
(m1 < m || n1 < n) && throw(DimensionMismatch("B of size ($m1,$n1) should have at least size ($m,$n)"))
end
@kernel function L_kernel!(_A, _B)
I = @index(Global, Cartesian)
i, j = Tuple(I)
Expand Down
7 changes: 7 additions & 0 deletions test/testsuite/linalg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,13 @@
B = zeros(T,n,n)
@test compare(copytrito!, AT, B, A, uplo)
end
@testset for T in eltypes, uplo in ('L', 'U')
n = 16
m = 32
A = uplo == 'U' ? rand(T,m,n) : rand(T,n,m)
B = zeros(T,n,n)
@test compare(copytrito!, AT, B, A, uplo)
end
end
end

Expand Down
Loading