Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Matern AD failures #528

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Fix Matern AD failures #528

merged 3 commits into from
Oct 23, 2023

Conversation

simsurace
Copy link
Member

Should provide a fix for #526 while the issues revolving around Distances/Zygote/ChainRulesCore are still open.

@codecov
Copy link

codecov bot commented Oct 6, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/basekernels/matern.jl 100.00% <100.00%> (+76.00%) ⬆️

... and 18 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@simsurace simsurace mentioned this pull request Oct 6, 2023
Open
5 tasks
@simsurace simsurace changed the title Try to fix Matern AD failures Fix Matern AD failures Oct 6, 2023
@devmotion devmotion mentioned this pull request Oct 6, 2023
Closed
@simsurace
Copy link
Member Author

I opened FluxML/Zygote.jl#1464 to track the issue that was unmasked here, as it will be masked once this is merged.

@simsurace
Copy link
Member Author

Bump. I think this should be merged if there are no blockers/change requests.

willtebbutt
willtebbutt approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Yeah, let's merge this.

Please bump the patch version before merging.

@willtebbutt
Copy link
Member

That being said -- do you know whether it's possible that the performance failures in Transform are at all related to this PR? I can't see how they would be 🤷

@simsurace
Copy link
Member Author

I don't think so. The performance seems to be the number of allocations not being deterministic anymore in Julia 1.9 vs. Julia 1.8, see #530. I haven't had time to look at the detailed profile output to understand where the occasional +1 allocation comes from.

@simsurace simsurace merged commit 0a6219a into master Oct 23, 2023
18 of 22 checks passed
@simsurace simsurace deleted the bugfix/matern branch October 23, 2023 14:10
@devmotion devmotion mentioned this pull request Oct 23, 2023
Open
simsurace added a commit to JuliaGaussianProcesses/AbstractGPs.jl that referenced this pull request Feb 10, 2024
@simsurace
Enable periodic kernel in example
d4ad9f2 
Now that JuliaGaussianProcesses/KernelFunctions.jl#528 has been merged, we can try re-enabling the `PeriodicKernel`
@simsurace simsurace mentioned this pull request Feb 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devmotion devmotion devmotion left review comments

@willtebbutt willtebbutt willtebbutt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simsurace @willtebbutt @devmotion