Optimize pairwise
for Sinus
and scalar inputs
#538
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A call like
kernelmatrix(PeriodicKernel(), rand(1000))
produces a number of allocations of the same order as the size of the kernel matrix becauseSinus
has a vector parameter and the dispatch hits a path which allocates that for each element of the kernel matrix.Proposed changes
We add two specialized methods that use broadcast.
What alternatives have you considered?
None.