Add test for == and fix method

JuliaGaussianProcesses · Feb 10, 2024 · 092bf04 · 092bf04
1 parent 73ad032
commit 092bf04
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/parameters_matrix.jl b/src/parameters_matrix.jl
@@ -98,7 +98,7 @@ struct PositiveDefinite{TL<:AbstractVector{<:Real},Tε<:Real} <: AbstractParamet
     ε::Tε
 end
 
-Base.:(==)(X::PositiveDefinite, Y::PositiveDefinite) = X.L == Y.L
+Base.:(==)(X::PositiveDefinite, Y::PositiveDefinite) = X.L == Y.L && X.ε == Y.ε
 
 value(X::PositiveDefinite) = A_At(vec_to_tril(X.L)) + X.ε * I
 

diff --git a/test/parameters_matrix.jl b/test/parameters_matrix.jl
@@ -61,6 +61,8 @@ using ParameterHandling: vec_to_tril, tril_to_vec
         @test isposdef(value(X))
         X.L .= 0 # zero the unconstrained value
         @test isposdef(value(X))
+        @test X != positive_definite(X_mat)
+        @test positive_definite(X_mat, 1e-3) != positive_definite(X_mat, 1e-2)
         @test_throws ArgumentError positive_definite(zeros(3, 3))
         @test_throws ArgumentError positive_definite(X_mat, 0.0)
         test_parameter_interface(X)
-Original file line number
+Diff line change
@@ Expand Up @@
         ε::Tε
     end
-    Base.:(==)(X::PositiveDefinite, Y::PositiveDefinite) = X.L == Y.L
+    Base.:(==)(X::PositiveDefinite, Y::PositiveDefinite) = X.L == Y.L && X.ε == Y.ε
     value(X::PositiveDefinite) = A_At(vec_to_tril(X.L)) + X.ε * I
@@ Expand Down @@