Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI runner #69

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Improve CI runner #69

merged 3 commits into from
Feb 6, 2024

Conversation

willtebbutt
Copy link
Member

It was out of date, and running stuff that we really didn't need to.

@willtebbutt willtebbutt requested a review from simsurace February 6, 2024 16:59
Copy link
Member

@simsurace simsurace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe checking the different OSs would not hurt?

@willtebbutt
Copy link
Member Author

@simsurace now running on all three OSs again. Let me know if there's anything else.

Copy link
Member

@simsurace simsurace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (567b070) 97.36% compared to head (0c992f8) 97.36%.

❗ Current head 0c992f8 differs from pull request most recent head 46a1802. Consider uploading reports for the commit 46a1802 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   97.36%   97.36%           
=======================================
  Files           8        8           
  Lines         228      228           
=======================================
  Hits          222      222           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willtebbutt willtebbutt merged commit 3d496be into master Feb 6, 2024
5 checks passed
@willtebbutt willtebbutt deleted the wct/drop-julia-1.5 branch February 6, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants