Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI badge #70

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Fix CI badge #70

merged 1 commit into from
Feb 6, 2024

Conversation

simsurace
Copy link
Member

The badge was broken...

The badge was broken...
@simsurace
Copy link
Member Author

simsurace commented Feb 6, 2024

I'd like to fix the coverage badge as well, but I don't know why the covarage report for master is not showing up on codecov.

EDIT: now it seems to work...

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d41e693) 97.41% compared to head (dbc917c) 97.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   97.41%   97.41%           
=======================================
  Files           8        8           
  Lines         232      232           
=======================================
  Hits          226      226           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simsurace simsurace merged commit 902fbe2 into master Feb 6, 2024
7 checks passed
@simsurace simsurace deleted the fix-CI-badge branch February 6, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants