Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't test polygonize with OffsetArrays #189

Closed
wants to merge 1 commit into from
Closed

Don't test polygonize with OffsetArrays #189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions test/methods/polygonize.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using GeometryOps, GeoInterface, Test
import OffsetArrays, DimensionalData, Rasters
import DimensionalData, Rasters
# import OffsetArrays

# Missing holes throw a warning, so testing there are
# no warnings in a range of randomisation is one way to test
Expand Down Expand Up @@ -41,6 +42,11 @@ end


@testset "Polygonize with exotic arrays" begin
# OffsetArrays does a bit of undesirable piracy,
# so we test without it for now.
# See https://github.com/JuliaGeo/GeometryOps.jl/issues/187
# and https://github.com/JuliaArrays/OffsetArrays.jl/issues/306
#=
@testset "OffsetArrays" begin
data = rand(1:4, 100, 100) .== 1
evil = OffsetArrays.Origin(-100, -100)(data)
Expand All @@ -51,6 +57,7 @@ end
end
@test GO.equals(data_mp, evil_in_data_space_mp)
end
=#
@testset "DimensionalData" begin
data = rand(1:4, 100, 100) .== 1
evil = DimensionalData.DimArray(data, (DimensionalData.X(1:100), DimensionalData.Y(1:100)))
Expand All @@ -66,4 +73,4 @@ end
@test GO.equals(data_mp, evil_mp)
@test GI.crs(evil_mp) == GI.crs(evil)
end
end
end
Loading