Add a utility function to GeometryOpsCore, to get geometries from any data structure #240
Conversation
a generic utility inspired by similar functions in Rasters.jl and elsewhere - returns a vector of the geometries in a given object, be it a feature collection, table, iterable of geometries, or whatever. Potential next steps: - `get_geometries(x) do geom` that rebuilds the given structure as far as possible - this is the same as `apply(::AbstractGeometryTrait)` though.... - treatment of dataframes with multiple columns
| elseif Tables.istable(x) && Tables.hascolumn(x, first(GI.geometrycolumns(x))) | ||
| return Tables.getcolumn(x, first(GI.geometrycolumns(x))) | ||
| else | ||
| c = collect(x) |
There was a problem hiding this comment.
Probably want to skip this if x is already an AbstractArray, you can have a do nothing condition
| if GI.isgeometry(x) | ||
| return x | ||
| # elseif GI.isgeometrycollection(x) | ||
| # return GI.getgeom(x) |
There was a problem hiding this comment.
This would need collect, and needs to be checked first
There was a problem hiding this comment.
Guess we could just run it through get_geometries again...if it's an abstractvector or tuple then it will be a no-op anyway
|
Is there a reason we didn't merge this? |
|
Don't think so...just waiting for me to make that one change you mentioned. I was thinking of checking Ah and dataframes / tables with multiple geometry columns. Probably also allowing passing a |
a generic utility inspired by similar functions in Rasters.jl and elsewhere - returns a vector of the geometries in a given object, be it a feature collection, table, iterable of geometries, or whatever.
Potential next steps:
get_geometries(x) do geomthat rebuilds the given structure as far as possible - this is the same asapply(::AbstractGeometryTrait)though....Also: do we want this here? in GeoInterface?