Algorithm + manifold and accelerator passthrough in clipping functions #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asinghvi17
changed the base branch from
as/clipping-changes
to
as/adaptivepredicates
This was referenced Mar 4, 2025
asinghvi17
force-pushed
the
as/adaptivepredicates
branch
from
60eabb9 to
b52ef6c
Compare
asinghvi17
force-pushed
the
as/clipping
branch
2 times, most recently
from
941f27d to
bc9a491
Compare
asinghvi17
force-pushed
the
as/adaptivepredicates
branch
from
b52ef6c to
f2d90a8
Compare
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
rafaqz
approved these changes
Mar 8, 2025
| struct DoubleSTRtree <: IntersectionAccelerator end | ||
| struct SingleNaturalTree <: IntersectionAccelerator end | ||
| struct DoubleNaturalTree <: IntersectionAccelerator end | ||
| struct ThinnedDoubleNaturalTree <: IntersectionAccelerator end |
There was a problem hiding this comment.
Is this the only one with thinning?
Wondering if it can be a type parameter
| """ | ||
| FosterHormannClipping{M <: Manifold, A <: Union{Nothing, Accelerator}} <: GeometryOpsCore.Algorithm{M} | ||
|
|
||
| A type that represents the Foster-Hormann clipping algorithm. |
There was a problem hiding this comment.
Suggested change
| A type that represents the Foster-Hormann clipping algorithm. | |
| Applies the Foster-Hormann clipping algorithm. |
Comment on lines
+48
to
+49
|
|
||
|
|
| _cut(T, GI.trait(geom), geom, GI.trait(line), line; exact = True()) | ||
| cut(geom, line, ::Type{T} = Float64) where {T <: AbstractFloat} = cut(FosterHormannClipping(), geom, line, T) | ||
| cut(m::Manifold, geom, line, ::Type{T} = Float64) where {T <: AbstractFloat} = cut(FosterHormannClipping(m), geom, line, T) | ||
|
|
| ) where {T<:AbstractFloat} | ||
| return _difference( | ||
| TraitTarget(target), T, GI.trait(geom_a), geom_a, GI.trait(geom_b), geom_b; | ||
| alg, TraitTarget(target), T, GI.trait(geom_a), geom_a, GI.trait(geom_b), geom_b; | ||
| exact = True(), kwargs..., | ||
| ) | ||
| end | ||
|
|
| ) where T | ||
| return UnionIntersectingPolygons(#=TODO: alg.manifold=#)(GI.MultiPolygon([poly_a, poly_b])) | ||
| end | ||
|
|
| return GI.MultiPolygon(res) | ||
| end | ||
| end | ||
|
|
| ) where T | ||
| union(alg, poly_b, multipoly_a; target, fix_multipoly, kwargs...) | ||
| end | ||
|
|
| ) where T | ||
| return GI.MultiPolygon(_union(alg, TraitTarget{GI.PolygonTrait}(), T, trait_a, multipoly_a, trait_b, multipoly_b; fix_multipoly, kwargs...)) | ||
| end | ||
|
|
| @@ -526,6 +526,11 @@ function _point_filled_curve_orientation( | |||
| return iseven(k) ? out : in | |||
| end | |||
|
|
|||
asinghvi17
force-pushed
the
as/adaptivepredicates
branch
from
f2d90a8 to
974a162
Compare
Not sure of name (too verbose, maybe Foster()?). Intersection accelerators will come into the picture later (next PR) but we need them now to instantiate the struct.
Better than printing out since we can (A) check on it and (B) access the polygons as well as the a_list and b_list in Julia. I have a few plot recipes for them but not sure if they are worth putting in a Makie extension...they would also be inaccessible there. Maybe in GeoMakie? Then we can make full use of customizations etc.
This is a shorter change list as a sampler, to show what needs to happen.
asinghvi17
force-pushed
the
as/adaptivepredicates
branch
from
974a162 to
5b0c4a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spun out from #259
Parent: #275 (adaptive predicates)
Child PRs: #274 (trees)
FosterHormannClipping(manifold, accelerator)algorithm - we can bikeshed the nameTracingErrorthat actually stores all the context including a_list and b_list, this way we can more effectively diagnose what's going on.