-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
return tuple points from GeoInterface methods #193
base: master
Are you sure you want to change the base?
Conversation
ee9e84e
to
519051a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With a merge from master this should be cleaner. I'm fine with this change, but only if we update our constructors to also take Vector of Tuples, so we can reverse.
nit: Please spellcheck your comments ;)
6e8a5a5
to
6d49003
Compare
Doing this for MultiPoint and coordSeq methods is a huge task that I cant include in this PR. This package needs a rewrite of the internals with the aim of reducing the constant small allocations with some ArchGDAL like closures for safety instead of clones. But who knows when that can happen. |
Closes #190