Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement weighted Delaunay triangulations and power diagrams #180

Merged
merged 21 commits into from
Sep 8, 2024

Conversation

DanielVandH
Copy link
Member

@DanielVandH DanielVandH commented Sep 6, 2024

TODO:

  • Implement weighted Delaunay triangulations
  • Implement power diagrams
  • Add triangle_orthocenter to public
  • Add tutorial example for power diagrams
  • Add math details for power diagrams and orthocenters
  • Look into implementing treemaps
  • Fix clipping
  • Fix smoothing
  • Add generic convex polygon clipping
  • Add example showing clipping to a generic convex polygon
  • Add examples to README

@DanielVandH DanielVandH linked an issue Sep 6, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 82.83379% with 63 lines in your changes missing coverage. Please review.

Project coverage is 95.00%. Comparing base (e88077b) to head (426b2a5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/algorithms/voronoi/clipped.jl 72.24% 58 Missing ⚠️
src/data_structures/voronoi.jl 50.00% 2 Missing ⚠️
...orithms/triangulation/constrained_triangulation.jl 50.00% 1 Missing ⚠️
src/utils/utils.jl 75.00% 1 Missing ⚠️
src/validation.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   94.77%   95.00%   +0.23%     
==========================================
  Files          95       95              
  Lines        9839    10112     +273     
==========================================
+ Hits         9325     9607     +282     
+ Misses        514      505       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielVandH DanielVandH marked this pull request as ready for review September 6, 2024 18:44
@DanielVandH DanielVandH changed the title WIP: Fix weighted Delaunay triangulations Implement weighted Delaunay triangulations power diagrams Sep 6, 2024
@DanielVandH DanielVandH closed this Sep 6, 2024
@DanielVandH DanielVandH reopened this Sep 6, 2024
@DanielVandH DanielVandH marked this pull request as draft September 6, 2024 21:29
@DanielVandH DanielVandH changed the title Implement weighted Delaunay triangulations power diagrams Implement weighted Delaunay triangulations and power diagrams Sep 6, 2024
@DanielVandH DanielVandH marked this pull request as ready for review September 8, 2024 18:40
@DanielVandH DanielVandH merged commit 4c58e00 into main Sep 8, 2024
6 of 8 checks passed
@DanielVandH DanielVandH deleted the better_bw branch September 8, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weighted triangulations don't work
1 participant