Clipping Voronoi tessellations to arbitrary bounding boxes #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 93.48% 94.08% +0.60%
==========================================
Files 73 75 +2
Lines 5446 5545 +99
==========================================
+ Hits 5091 5217 +126
+ Misses 355 328 -27
☔ View full report in Codecov by Sentry. |
|
Returns nothing for |
The issue was with my incorrect polygon-in-polygon predicate. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After countless failed attempts at a generalised Sutherland-Hodgman algorithm, this PR introduces clipping Voronoi tessellations to arbitrary bounding boxes. In particular,
get_polygon_coordinatesnow allows for a bounding box that doesn't necessarily contain all circumcenters/generators. This is especially needed for MakieOrg/Makie.jl#3102.For finite polygons: The Sutherland-Hodgman algorithm is used.
For unbounded polygons: The polygon is truncated so that the unbounded edges can be connected such that the line connecting them is entirely outside of the provided bounding box, using the Liang-Barsky algorithm to detect box-line segment intersections, and then the resulting finite polygon is clipped using the Sutherland-Hodgman algorithm.
This PR also:
get_polygon_coordinatesinside Voronoi docstrings.Note that clipping, i.e.
voronoi(tri, true), will still only clip to the convex hull. It would be possible to add that, e.g. add a kwargclip_to_hullor something, together with a bounding box kwarg if!clip_to_hull, but I do not see the need for that since only the rectangular case is simple to do for each polygon in isolation. PRs are welcome if you do want this.