Skip to content

Commit

Permalink
Fix tests and bump CxxWrap compat
Browse files Browse the repository at this point in the history
  • Loading branch information
barche committed Jun 17, 2024
1 parent e8ebdd9 commit d8095f6
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jlqml_jll = "6b5019fb-a83d-5b4e-a9f7-678a36c28df7"

[compat]
ColorTypes = "0.11"
CxxWrap = "0.15.1"
CxxWrap = "0.16"
MacroTools = "0.5"
Observables = "0.5"
Requires = "1.0"
Expand Down
3 changes: 1 addition & 2 deletions src/QML.jl
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ end
end

function load_qml(qmlfilename, engine)
ctx = root_context(CxxRef(engine))
if !load_into_engine(engine, QString(qmlfilename))
error("Failed to load QML file ", qmlfilename)
end
Expand All @@ -96,8 +95,8 @@ function loadqml(qmlfilename; kwargs...)
try
return load_qml(qmlfilename, qml_engine)
catch
cleanup()
QML.process_events()
cleanup()
rethrow()
end
end
Expand Down
2 changes: 1 addition & 1 deletion test/qml/tableview.qml
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ ApplicationWindow {
Item {

Layout.alignment: Qt.AlignCenter
Layout.preferredWidth: 100
Layout.preferredWidth: 300
Layout.preferredHeight: 200

HorizontalHeaderView {
Expand Down

0 comments on commit d8095f6

Please sign in to comment.