Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [GNNLux] Adding TransformerConv Layer #501

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

rbSparky
Copy link
Contributor

Adding conv layer according to #461

@rbSparky
Copy link
Contributor Author

rbSparky commented Sep 30, 2024

tests work with skip connection false

but fail with skip connection true

dimension error:

Error in testset "TransformerConv" on worker 2157:
Error During Test at /home/runner/work/GraphNeuralNetworks.jl/GraphNeuralNetworks.jl/GNNLux/test/layers/conv_tests.jl:8
Got exception outside of a @test
DimensionMismatch: A has shape (16, 16) but B has shape (6, 10)

will also fix the GNN test since that is due to change of variable name

@rbSparky
Copy link
Contributor Author

rbSparky commented Oct 3, 2024

@CarloLucibello let me know if you have ideas to fix with skip connection
I will look further into it too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants