-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to ColorVectorSpace 0.9 and reduce latency #157
Conversation
Through better design and precompilation, this shaves about 30% off the time to run the tests.
Test failures are due to |
I think SpatioTemporalTraits.jl is at a point where the next set of changes will probably be tests, updating the README, and changes b/c of feedback. I'm currently trying to get rid of a bunch of dead code elsewhere that ArrayInterface now houses instead (and a whole lot of related experimental bloat code). Once that's done I should be able to get robust tests for SpatioTemporalTraits, using AxisIndices.jl (which liberally borrows tests from most of the array provides that Images.jl uses). The code is already fairly well optimized because it uses ArrayInterface.jl for getting dimensions and axes across permuted/subset/transposed dimensions. I'm hoping we can slowly get more packages using ArrayInterface, which will make it so that we don't have to define a bunch of new parametric types for packages like MosaicArrays to work with spatially labelled dimensions. For the time being I'll probably have to replace some calls to You could probably start looking at the the code if you want to ensure you at least feel comfortable with the syntax. I was hoping to get too some backend stuff in ArrayInterface that would make it easy to support MappedArrays, but that might have to wait a couple weeks because my schedule is pretty crazy for the next week. |
To smoothly migrate to ColorVectorSpace(CVS) 0.9, I'll separate the task into three steps:
Otherwise, it's a little bit hard to make the CI and Pkg happy. |
This makes CI happy because downstream consumers has not yet decleared their compatibility to ImageCore 0.9
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
==========================================
- Coverage 66.42% 62.56% -3.87%
==========================================
Files 10 10
Lines 563 561 -2
==========================================
- Hits 374 351 -23
- Misses 189 210 +21
Continue to review full report at Codecov.
|
So far the test passes; it seems that this PR is ready but @timholy I'll leave it to you to decide whether it's okay to merge. To make CI happy, I've restored the version number back to 0.8.22, so we'll need to bump it again to 0.9.0 after merging this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After separating some of the codes into separated PRs, the changes now look good and safe to me. I'll for a few days and merge this.
Thanks for merging this! |
welcome back 😄 |
Thanks! It's nice to be back. My immediate goal is to get my JuliaCon stuff ready but after that I should slowly catch up. There are something like 8k "non-triagable" notifications so it may take a bit of time. |
Through better design and precompilation, this shaves about 30% off the
time to run the tests. Of course, the more important consequence is that it
should reflect reductions in "time to first computation" for typical usage.
Perhaps the biggest change, though, is this now loads ColorVectorSpace (the new version 0.9) so that it's always loaded throughout JuliaImages.
closes #158