Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unwrap rawview(::channelview) with one reshape reinterpret #175

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnnychen94
Copy link
Member

This does not fix #174 but could be potentially a good change by eliminating one mapped array wrapper.

@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #175 (0eb4993) into master (ff7afc0) will decrease coverage by 0.44%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
- Coverage   62.26%   61.81%   -0.45%     
==========================================
  Files          10       10              
  Lines         583      584       +1     
==========================================
- Hits          363      361       -2     
- Misses        220      223       +3     
Impacted Files Coverage Δ
src/ImageCore.jl 73.33% <100.00%> (+0.91%) ⬆️
src/show.jl 58.33% <0.00%> (-12.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7afc0...0eb4993. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Julia 1.7 performance regression on rawview
1 participant