Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split upload_rr_trace to enable manual upload. #145

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Nov 14, 2023

Automatic uploading of the trace can sometimes fail, see e.g. JuliaGPU/CUDA.jl#2163 (comment). In this PR, I provide a fallback, where the user can still manually upload a trace if the upload was interrupted or canceled.

@Liozou I changed the errormonitor logic you added in #144; IIUC all errors should have been reported by errormonitor, so it should be safe to just return from the catch block.

@Liozou
Copy link
Member

Liozou commented Nov 14, 2023

Sure, that also works! The control flow will be different though since errormonitor does not interrupt the computation, it only prints an error message if there is a problem (typically a network error) so what used to be rethrown will now simply print an error message and return nothing instead. I think it's fine.

@maleadt maleadt merged commit 7823619 into master Nov 15, 2023
1 check passed
@maleadt maleadt deleted the tb/manual_upload branch November 15, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants