Split upload_rr_trace to enable manual upload. #145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic uploading of the trace can sometimes fail, see e.g. JuliaGPU/CUDA.jl#2163 (comment). In this PR, I provide a fallback, where the user can still manually upload a trace if the upload was interrupted or canceled.
@Liozou I changed the
errormonitor
logic you added in #144; IIUC all errors should have been reported byerrormonitor
, so it should be safe to just return from thecatch
block.