Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination zeros from eltype in zero-length generic_matvecmul #1241

Merged
merged 3 commits into from
Apr 1, 2025

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Mar 16, 2025

This fixes issues like

julia> A = fill(@SMatrix(zeros(2,2)), 4, 0)
4×0 Matrix{SMatrix{2, 2, Float64, 4}}

julia> v = fill(@SMatrix(zeros(2,2)), size(A,2))
SMatrix{2, 2, Float64, 4}[]

julia> A * v
ERROR: MethodError: Cannot `convert` an object of type Bool to an object of type SMatrix{2, 2, Float64, 4}
The function `convert` exists, but no method is defined for this combination of argument types.
[...]

@jishnub
Copy link
Member Author

jishnub commented Mar 17, 2025

@KristofferC The linux-i686 job is running out of time frequently, and is being terminated after 1 hr. Would it be possible to increase the time limit for the job?

@KristofferC KristofferC force-pushed the jishnub/generic_matvecmul_zero_fill branch from 9f74b74 to 451f015 Compare April 1, 2025 07:42
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (7f1dfe4) to head (451f015).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1241       +/-   ##
===========================================
+ Coverage    0.00%   92.02%   +92.02%     
===========================================
  Files          34       34               
  Lines       15738    15461      -277     
===========================================
+ Hits            0    14228    +14228     
+ Misses      15738     1233    -14505     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jishnub jishnub merged commit bfdb742 into master Apr 1, 2025
4 checks passed
@jishnub jishnub deleted the jishnub/generic_matvecmul_zero_fill branch April 1, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants