Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dispatch to herk #1247

Merged
merged 2 commits into from
Apr 1, 2025
Merged

fix dispatch to herk #1247

merged 2 commits into from
Apr 1, 2025

Conversation

araujoms
Copy link
Contributor

The herk wrapper was testing whether C was symmetric instead of Hermitian, thus preventing the dispatch from occurring for essentially all nonzero β.

@stevengj
Copy link
Member

LGTM. Do we have test coverage for this branch?

@ViralBShah
Copy link
Member

ViralBShah commented Mar 26, 2025

Why are all the tests failing? I couldn't tell from a quick glance.

@KristofferC
Copy link
Member

My guess is that the lazy jll stuff broke them.

@araujoms
Copy link
Contributor Author

I've found another typo, this time in syrk_wrapper!, I thought it would be better to add it here.

@ViralBShah
Copy link
Member

The dot-jl job seems to fail with:

🚨 Error: mkdir C:\cache: Cannot create a file when that file already exists.

@KristofferC
Copy link
Member

This happens to many windows buildkite workers in the ecosystem (and for Julia itself).

@dkarrasch
Copy link
Member

I'll merge this and move forward with cleaning up the herk_wrapper!.

@dkarrasch dkarrasch merged commit e64a3df into JuliaLang:master Apr 1, 2025
1 of 2 checks passed
@araujoms araujoms deleted the patch-1 branch April 1, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants