-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix dispatch to herk #1247
fix dispatch to herk #1247
Conversation
LGTM. Do we have test coverage for this branch? |
Why are all the tests failing? I couldn't tell from a quick glance. |
My guess is that the lazy jll stuff broke them. |
I've found another typo, this time in |
The dot-jl job seems to fail with:
|
This happens to many windows buildkite workers in the ecosystem (and for Julia itself). |
I'll merge this and move forward with cleaning up the |
The herk wrapper was testing whether
C
was symmetric instead of Hermitian, thus preventing the dispatch from occurring for essentially all nonzeroβ
.