Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Pull request/a889282b #2206

Closed
wants to merge 2 commits into from
Closed

Pull request/a889282b #2206

wants to merge 2 commits into from

Conversation

timothyrenner
Copy link
Contributor

Registering ColorBrewer package.

@IainNZ
Copy link
Member

IainNZ commented Feb 25, 2015

Hey @timothyrenner, I just saw this issue JuliaAttic/Color.jl#77 and I was curious why this wasn't added to Color.jl?

@IainNZ
Copy link
Member

IainNZ commented Feb 25, 2015

In fact some of it already seems to be in there, and theres even a file that seems to depend on this package.

@timothyrenner
Copy link
Contributor Author

I didn't add it to Color.jl because in my original search for colorbrewer palettes in Julia I noticed they've been discussed in various places (GiovineItalia/Gadfly.jl#21, JuliaLang/julia#2278, JuliaGraphics/Winston.jl#105). In these cases the authors preferred algorithmic solutions. At that point I assumed it would be easier to just write my own.

The file in Color.jl that requires this package was written by @ikirill to generate the colormaps for the READMEs. It's present in ColorBrewer.jl and Color.jl.

@IainNZ
Copy link
Member

IainNZ commented Feb 25, 2015

OK, I see. I'm just bugging you about it because we have a preference wherever possible to reduce duplication. It definitely seems like a difference of perspective then, I didn't realize before you actually have the maps stored as data. CC @timholy @dcjones @jiahao, the people I think of when I think of colors.

I won't merge this just yet, because I think you probably should tag a version (v"0.1") so people can Pkg.add it.

@dcjones
Copy link
Contributor

dcjones commented Feb 25, 2015

This looks good. Ultimately it would be nice to unify this with the palette code in Color, possibly splitting it into a separate ColorPalettes package.

@timothyrenner
Copy link
Contributor Author

@dcjones I agree - something like brewer("Greens", 5) for a colorbrewer palette would be a nice way to integrate it with algorithmic palettes.

@IainNZ I'm going to tag shortly.

@jiahao jiahao closed this Feb 26, 2015
@timothyrenner timothyrenner deleted the pull-request/a889282b branch February 26, 2015 03:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants