Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix benchmarks link on julia website #61

Merged
merged 1 commit into from
May 10, 2022
Merged

Conversation

acxz
Copy link
Contributor

@acxz acxz commented Mar 23, 2022

Benchmarks are not located on the homepage anymore

The website does not include the table anymore

@acxz
Copy link
Contributor Author

acxz commented Mar 24, 2022

Considering the output of the table.jl file is not used, I believe it makes sense to actually remove the file.

@LilithHafner
Copy link
Member

A table is still available here: https://julialang.org/assets/benchmarks/benchmarks.csv. I think we should link to those tabular results directly from README.md. When I saw this repo, one of the first things I wanted to see was tabular results on someone else's machine.

I also think table.jl is also needed for regression testing so we can't remove it (see failed CI run for this PR):

make: *** No rule to make target 'bin/table.jl', needed by 'gh_action_benchmarks.html'.  Stop.

@acxz
Copy link
Contributor Author

acxz commented Mar 30, 2022

A table is still available here:

This is actually the csv file and not the table. The csv file is not displayed anywhere on the website and the plan is to delete this file in a future PR to www.julialang.org once #62 is merged.

I think we should link to those tabular results directly from README.md.

This may be a good idea however, it is outside the scope of this PR.
Edit: Actually we could just slap the html table onto the readme, hmm.... let's see what other reviewers have to say. In the meanwhile we'll keep the unused bin/table.jl file around.

I also think table.jl is also needed for regression testing so we can't remove it

Good catch, let me fix real quick.

Benchmarks are not located on the homepage anymore

The website does not include the table anymore
@acxz acxz merged commit 94b36f3 into JuliaLang:master May 10, 2022
@acxz acxz deleted the patch-1 branch May 10, 2022 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants