Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embedding_wrapper.c: Fix Unicode arguments in Windows #1008

Merged
merged 9 commits into from
Nov 25, 2024

Conversation

raphasampaio
Copy link
Contributor

@DilumAluthge
Copy link
Member

Would it be possible to add a test?

@DilumAluthge DilumAluthge changed the title Fix Unicode arguments in Windows embedding_wrapper.c: Fix Unicode arguments in Windows Nov 21, 2024
@raphasampaio
Copy link
Contributor Author

Sure @DilumAluthge

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.76%. Comparing base (9bef815) to head (127c545).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1008      +/-   ##
==========================================
+ Coverage   87.73%   87.76%   +0.03%     
==========================================
  Files           3        3              
  Lines         799      801       +2     
==========================================
+ Hits          701      703       +2     
  Misses         98       98              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@KristofferC KristofferC merged commit 35b3e18 into JuliaLang:master Nov 25, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Special characters in Julia ARGS
3 participants